[tomboy-list] Work on Bug #588730

[Abhinav Upadhyay]

Hi Johannes,

Thanks for your feedback and help :-)

My first try was to use Gtk.LinkButton and display it in the Matches column
of the Search Window. But, I could not find any easy way of doing this. As
far as I could search around, Gtk# doesn't provide this functionality,
(writing a custom CellRenderer would be an option, but I am totally new to
Gtk#, doing that will take me ages). And therefore, I opted for a simpler
approach. The code that I have added for this is also quite less.
By the way, do you have any idea, how can a widget be added to a
TreeViewColumn ?

I was keeping the No button to provide the user the option of restoring the
default TreeView, removing the Question and buttons. But I think, selecting
another Notebook from the left should do that automatically.


Your 2nd idea is also good, but it will require revamping the main interface
as well has refactoring a lot of code (I guess). A more experienced
developer would be in a better position to do that :-) . I started with this
bug because it seemed simple enough and it allowed me to learn the internals
of Tomboy.

The 2nd idea given in the bug report, of displaying the number of all
matches, I think it should be done as an independent patch, as Sandy said in
his comment.

On Sun, Mar 6, 2011 at 3:21 PM, Johannes Buchner <buchner.johannes at gmx.at>wrote:

> Hi Abhinav,
>
> Thanks for your contributions!
>
> How do you feel about replacing the question+buttons with a hyperlink:
> "No results found within this notebook. <a href="searchall()">Search all
> notebooks</a>
> I've seen this in several UIs, and I think it is short and obvious. On the
> other hand, I've never seen a link in GNOME, so it may not be acceptable for
> the GNOME UI guidelines.
>
> There is no reason to ever press the No-button.
>
> I am totally bikeshedding here, feel free to ignore me.
>
> Another idea: The search window could be re-thought to be a filter window,
> where you can filter by notebook and by keywords. If they are given equal
> weight in the UI, this could be more intuitive and the question be left out.
> For example, if the label next to the search box said "Filter by keywords"
> and a label above to the notebooks said "filter by notebook", the problem in
> the bug wouldn't appear, as it is obvious that it's doubly filtered.
>
> I like the idea in the bug of displaying the number of all results, this
> gives another hint (discoverability yay).
>
> Cheers,
> Johannes
>
>   ----- Ursprüngliche Nachricht -----
>   Von: Abhinav Upadhyay
>   Gesendet: 06.03.11 20:26 Uhr
>   An: tomboy-list at lists.beatniksoftware.com
>   Betreff: [tomboy-list] Work on Bug #588730
>
>    Hi all.
>     I am working on Bug #588730 (
> https://bugzilla.gnome.org/show_bug.cgi?id=588730). I have almost
> completed it. I am mostly confused if the UI that I have created looks
> elegant or not , as the rest of the UI of Tomboy is quite neat and elegant.
>    I am posting a screenshot of the UI, please take a look at it.
> http://img6.imagebanana.com/img/e88el2tl/SearchAllNotes_007.png      If
> there are no matches found in the search, then this message is displayed
> instead of the TreeView. Initially, I was thinking to add a Gtk.LinkButton
> to the "Matches" column of Gtk.TreeView but, I could not find any such
> functionality in Gtk# (currently it supports, TextEntry, Combo and Spin
> Buttons in a CellRenderer). If there is an easy way to do that then please
> tell me, as I think that would look better than this.      Or, if you feel
> that it looks Ok, then also please tell me, so that I may submit the patch.
> We can work  later on improving this and submit another patch ?    Thanks
> for your help.  Abhinav Upadhyay
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.beatniksoftware.com/pipermail/tomboy-list-beatniksoftware.com/attachments/20110306/c906d12f/attachment.htm>